JDevlieghere added a comment.

I'm on the fence on this one. I think the `==` pattern attracts more attention 
to the fact that we are comparing strings. However, I also see the benefit, 
like in the example, where even a temporary variable wouldn't help much.

Regarding the name, how would you feel about `anyOf` instead? Although not 
relevant here, it has a nice duality with `allOf`. I think this is what the AST 
matchers use.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61231/new/

https://reviews.llvm.org/D61231



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to