clayborg added a comment. I agree with all that was said above.
My reason for leaving it in SBHostOS is due to SBCommandInterpreter not being the right place, since we don't have SBScriptInprereter in the API, and we might as well leave it in SBHostOS until we are going to do it right by having a static call on SBScriptInterpreter that takes a enumeration from lldb-enumerations.h with a list of script interpreter languages that could be supported. Right now we just have python, so no need to add that functionality yet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61090/new/ https://reviews.llvm.org/D61090 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits