JosephTremoulet added a comment.

In D59991#1475694 <https://reviews.llvm.org/D59991#1475694>, @labath wrote:

> gcc-5.4 technically supported, so we can try to make things work for you. I'd 
> be best if you can create a patch that will make things work for you (since 
> it's kinda hard for me to test that). Or at least, can you paste the contents 
> of your cpuid.h somewhere?


Ok.  I'd be happy to put a patch together... is there an existing pattern for 
this sort of thing that I should follow?  E.g. define a helper 
llvm::get_cpuid_count function somewhere, similar to STLExtras?  Or just define 
it in this file?  Looking at the implementation of __get_cpuid_count in libc++, 
it's pretty short, my instinct would be to just inline that logic into the 
callsite here... LMK if there's a preferred approach.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59991/new/

https://reviews.llvm.org/D59991



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to