teemperor created this revision.
teemperor added a reviewer: LLDB.
Herald added subscribers: lldb-commits, kristof.beyls, javed.absar.
Herald added a project: LLDB.
As reported in LLVM bug 41486, the check `(byte1 & 0xf8) == 0xc0` is wrong. We
want to check for `11010nnn`,
so the proper value we want to compare against is `0xd0` (`0xc0` would check
for the value `11010nnn` which we
already checked for above as described in the bug report).
Repository:
rLLDB LLDB
https://reviews.llvm.org/D60655
Files:
lldb/source/Symbol/ArmUnwindInfo.cpp
Index: lldb/source/Symbol/ArmUnwindInfo.cpp
===================================================================
--- lldb/source/Symbol/ArmUnwindInfo.cpp
+++ lldb/source/Symbol/ArmUnwindInfo.cpp
@@ -304,7 +304,7 @@
// 11001yyy
// Spare (yyy != 000, 001)
return false;
- } else if ((byte1 & 0xf8) == 0xc0) {
+ } else if ((byte1 & 0xf8) == 0xd0) {
// 11010nnn
// Pop VFP double-precision registers D[8]-D[8+nnn] saved (as if) by
// FSTMFDD (see remark d)
Index: lldb/source/Symbol/ArmUnwindInfo.cpp
===================================================================
--- lldb/source/Symbol/ArmUnwindInfo.cpp
+++ lldb/source/Symbol/ArmUnwindInfo.cpp
@@ -304,7 +304,7 @@
// 11001yyy
// Spare (yyy != 000, 001)
return false;
- } else if ((byte1 & 0xf8) == 0xc0) {
+ } else if ((byte1 & 0xf8) == 0xd0) {
// 11010nnn
// Pop VFP double-precision registers D[8]-D[8+nnn] saved (as if) by
// FSTMFDD (see remark d)
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
