clayborg added inline comments.
================ Comment at: lldb/tools/lldb-mi/MICmdCmdData.cpp:420 + std::unique_ptr<char[]> pPathBuffer(new char[PATH_MAX]); + lineEntry.GetFileSpec().GetPath(pPathBuffer.get(), PATH_MAX); ---------------- There is a variant of FileSpec::GetPath() that returns a std::string: ``` std::string path = lineEntry.GetFileSpec().GetPath(); ``` Then you can get rid of the code above: ``` std::unique_ptr<char[]> pPathBuffer(new char[PATH_MAX]); ``` Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59015/new/ https://reviews.llvm.org/D59015 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits