[Lldb-commits] [PATCH] D59960: Fix for ambiguous lookup in expressions between local variable and namespace

[Frederic Riss via Phabricator via lldb-commits]

friss added inline comments.


================
Comment at: source/Expression/ExpressionSourceCode.cpp:181
+
+    if (var_name == ConstString("this") && wrapping_language == 
lldb::eLanguageTypeC_plus_plus )
       continue;
----------------
This should also trigger for eLanguageTypeObjC_plus_plus


================
Comment at: source/Expression/ExpressionSourceCode.cpp:356
+            tagged_body.c_str());
+            //m_name.c_str(), m_name.c_str(), tagged_body.c_str());
       }
----------------
Remove that comment, also I don't think the test case covers this codepath?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59960/new/

https://reviews.llvm.org/D59960



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits