sgraenitz added a comment. > [LLVM_LIBRARY_DIR is] not a cache variable when it's an in-tree build
Great, then please go ahead. > From what I remember, you added back [...] Yes this was a quick-fix. I didn't have the patience in that moment to check each of them individually. > If there's a situation where any of these variables don't get propagated from > the LLVMConfig, I'd like to know about it so I can add comments above these > variables explaining why these variables are set since it's non-obvious just > from grepping the lldb tree. It's usually a good idea to check both, the LLVMConfig.cmake from a build-tree and from an install-tree. They are quite different and LLDB standalone should work with both. You can check the green dragon bot that we added recently: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-standalone/ It builds against both versions (and BTW it also dumps CMake cache entries). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60180/new/ https://reviews.llvm.org/D60180 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
