clayborg added inline comments.
================
Comment at: include/lldb/Target/Target.h:535
+ bool notify,
+ Status *error_ptr = nullptr);
----------------
Pavel had questions about this error. If we specify an error when we call this,
is there a way to get a valid module shared pointer back and still get an
error? Maybe this should be one of the llvm::ErrorOr return types?
================
Comment at: source/Commands/CommandObjectTarget.cpp:399-400
+ const bool notify = true;
+ ModuleSP module_sp = target_sp->AddModule(main_module_spec,
+ notify);
if (module_sp)
----------------
Remove all "const bool notify = true; "statements and Inline with comment?
```
ModuleSP module_sp = target_sp->AddModule(main_module_spec,
true /*notify*/);
```
This would apply everywhere in this patch if so.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60172/new/
https://reviews.llvm.org/D60172
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
