labath marked an inline comment as done. labath added a comment. Thanks.
BTW, do you have any thoughts where this code could live (it can't stay here because I need to access it from SymbolFileBreakpad too). I was thinking of the Symbol library, as both users are `SymbolFile`s. I don't think this will have any external dependencies (that I can't get rid of), so another option might be Utility, but that seems a bit too low for this functionality (it will include code for generating dwarf expressions). ================ Comment at: source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:287 + + // lookup register reference as lvalue in preceding assignments + auto it = m_dependent_programs.find(symbol->GetName()); ---------------- amccarth wrote: > nit: As long as you're correcting this comment, can you fix "look up" to be > two words? will do. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60068/new/ https://reviews.llvm.org/D60068 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
