jasonmolenda marked an inline comment as done.
jasonmolenda added inline comments.
================
Comment at:
packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestWriteMemory.py:19-20
+ target = self.dbg.CreateTarget('')
+ if self.TraceOn():
+ self.runCmd("log enable gdb-remote packets")
+ process = self.connect(target)
----------------
davide wrote:
> I'm not sure you really need this, we can commit it if we need to debug.
> Please note that the bots always run with `TraceOn() == True`.
no big deal, but fwiw I put this sequence in every time I write a gdb remote
client test - it's essential for debugging any problems with them. The amount
of output is very small, it's not like a real debug session.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60022/new/
https://reviews.llvm.org/D60022
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
