jgorbe created this revision. jgorbe added a reviewer: clayborg. Herald added a subscriber: mgorny. Herald added a project: LLDB.
In the current state, 'ninja check-lldb' runs the lldb-vscode tests, but it won't rebuild lldb-vscode if any of its sources has changed. This is very confusing when you fix something and the tests keep failing, or vice versa. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D59828 Files: lldb/CMakeLists.txt Index: lldb/CMakeLists.txt =================================================================== --- lldb/CMakeLists.txt +++ lldb/CMakeLists.txt @@ -91,6 +91,10 @@ list(APPEND LLDB_TEST_DEPS lldb-mi) endif() + if(TARGET lldb-vscode) + list(APPEND LLDB_TEST_DEPS lldb-vscode) + endif() + if(TARGET lldb-instr) list(APPEND LLDB_TEST_DEPS lldb-instr) endif()
Index: lldb/CMakeLists.txt =================================================================== --- lldb/CMakeLists.txt +++ lldb/CMakeLists.txt @@ -91,6 +91,10 @@ list(APPEND LLDB_TEST_DEPS lldb-mi) endif() + if(TARGET lldb-vscode) + list(APPEND LLDB_TEST_DEPS lldb-vscode) + endif() + if(TARGET lldb-instr) list(APPEND LLDB_TEST_DEPS lldb-instr) endif()
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits