clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land.
Be nice to move DWARFContext out of the lldb_private namespace at some point, but I didn't catch this on other patches so this won't hold up this patch. ================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFBaseDIE.h:23-26 +namespace lldb_private { +class DWARFContext; +} + ---------------- Why are we defining DWARFContext in the lldb_private namespace? I missed prior patches doing this, but we should start putting plug-in code in plug-in specific namespace at some point. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59651/new/ https://reviews.llvm.org/D59651 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits