jhenderson added a comment. In D59291#1427349 <https://reviews.llvm.org/D59291#1427349>, @labath wrote:
> So, if we want to split this up more, I can propose the following: > > - split off the BinaryFormat&Object changes into a separate patch, test it > with some inline C char arrays > - write the yaml2obj equivalent of this patch, test it via unit tests and the > Object minidump reader > - finally, come back to this patch (obj2yaml), test it via `yamlobj|obj2yaml` > round-tripping > > What do you think? This sounds like a reasonable breakdown to me. Another possibility for testing yaml2obj is some form of minidump support in llvm-readobj or similar, which uses the Object minidump reader to verify things in lit tests. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59291/new/ https://reviews.llvm.org/D59291 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
