This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB355470: [Reproducers] Enable replay from SBRepro.
(authored by JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D58565?vs=188016&id=189432#toc
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58565/new/
https://reviews.llvm.org/D58565
Files:
lit/Reproducer/Inputs/FileReplay.in
lit/Reproducer/Inputs/GDBRemoteReplay.in
lit/Reproducer/TestFileRepro.test
lit/Reproducer/TestGDBRemoteRepro.test
source/API/SBReproducer.cpp
tools/driver/Driver.cpp
Index: tools/driver/Driver.cpp
===================================================================
--- tools/driver/Driver.cpp
+++ tools/driver/Driver.cpp
@@ -905,7 +905,7 @@
WithColor::error() << "reproducer replay failed: " << error << '\n';
return 1;
}
- // FIXME: Return once SBReproducer::Replay actually performs the replay.
+ return 0;
}
SBError error = SBDebugger::InitializeWithErrorHandling();
Index: source/API/SBReproducer.cpp
===================================================================
--- source/API/SBReproducer.cpp
+++ source/API/SBReproducer.cpp
@@ -2901,8 +2901,6 @@
return error.c_str();
}
- // FIXME: Enable the following code once the SB reproducer has landed.
-#if 0
FileSpec file = loader->GetFile<SBInfo>();
if (!file) {
error = "unable to get replay data from reproducer.";
@@ -2911,7 +2909,6 @@
SBRegistry registry;
registry.Replay(file);
-#endif
return nullptr;
}
Index: lit/Reproducer/TestGDBRemoteRepro.test
===================================================================
--- lit/Reproducer/TestGDBRemoteRepro.test
+++ lit/Reproducer/TestGDBRemoteRepro.test
@@ -7,8 +7,8 @@
# that the string "testing" is not printed.
# RUN: %clang %S/Inputs/simple.c -g -o %t.out
-# RUN: %lldb -x -b -s %S/Inputs/GDBRemoteCapture.in --capture %t.repro --
%t.out | FileCheck %s --check-prefix CHECK --check-prefix CAPTURE
-# RUN: %lldb -x -b -s %S/Inputs/GDBRemoteReplay.in --replay %t.repro -- %t.out
| FileCheck %s --check-prefix CHECK --check-prefix REPLAY
+# RUN: %lldb -x -b -s %S/Inputs/GDBRemoteCapture.in --capture %t.repro %t.out
| FileCheck %s --check-prefix CHECK --check-prefix CAPTURE
+# RUN: %lldb --replay %t.repro | FileCheck %s --check-prefix CHECK
--check-prefix REPLAY
# CHECK: Breakpoint 1
# CHECK: Process {{.*}} stopped
Index: lit/Reproducer/TestFileRepro.test
===================================================================
--- lit/Reproducer/TestFileRepro.test
+++ lit/Reproducer/TestFileRepro.test
@@ -7,9 +7,9 @@
# that the string "testing" is not printed.
# RUN: %clang %S/Inputs/simple.c -g -o %t.out
-# RUN: %lldb -x -b -s %S/Inputs/FileCapture.in --capture %t.repro -- %t.out |
FileCheck %s --check-prefix CHECK --check-prefix CAPTURE
+# RUN: %lldb -x -b -s %S/Inputs/FileCapture.in --capture %t.repro %t.out |
FileCheck %s --check-prefix CHECK --check-prefix CAPTURE
# RUN: rm %t.out
-# RUN: %lldb -x -b -s %S/Inputs/FileReplay.in --replay %t.repro -- %t.out |
FileCheck %s --check-prefix CHECK --check-prefix REPLAY
+# RUN: %lldb --replay %t.repro | FileCheck %s --check-prefix CHECK
--check-prefix REPLAY
# CAPTURE: testing
# REPLAY-NOT: testing
Index: lit/Reproducer/Inputs/FileReplay.in
===================================================================
--- lit/Reproducer/Inputs/FileReplay.in
+++ lit/Reproducer/Inputs/FileReplay.in
@@ -1,2 +0,0 @@
-reproducer status
-run
Index: lit/Reproducer/Inputs/GDBRemoteReplay.in
===================================================================
--- lit/Reproducer/Inputs/GDBRemoteReplay.in
+++ lit/Reproducer/Inputs/GDBRemoteReplay.in
@@ -1,5 +0,0 @@
-reproducer status
-breakpoint set -f simple.c -l 12
-run
-bt
-cont
Index: tools/driver/Driver.cpp
===================================================================
--- tools/driver/Driver.cpp
+++ tools/driver/Driver.cpp
@@ -905,7 +905,7 @@
WithColor::error() << "reproducer replay failed: " << error << '\n';
return 1;
}
- // FIXME: Return once SBReproducer::Replay actually performs the replay.
+ return 0;
}
SBError error = SBDebugger::InitializeWithErrorHandling();
Index: source/API/SBReproducer.cpp
===================================================================
--- source/API/SBReproducer.cpp
+++ source/API/SBReproducer.cpp
@@ -2901,8 +2901,6 @@
return error.c_str();
}
- // FIXME: Enable the following code once the SB reproducer has landed.
-#if 0
FileSpec file = loader->GetFile<SBInfo>();
if (!file) {
error = "unable to get replay data from reproducer.";
@@ -2911,7 +2909,6 @@
SBRegistry registry;
registry.Replay(file);
-#endif
return nullptr;
}
Index: lit/Reproducer/TestGDBRemoteRepro.test
===================================================================
--- lit/Reproducer/TestGDBRemoteRepro.test
+++ lit/Reproducer/TestGDBRemoteRepro.test
@@ -7,8 +7,8 @@
# that the string "testing" is not printed.
# RUN: %clang %S/Inputs/simple.c -g -o %t.out
-# RUN: %lldb -x -b -s %S/Inputs/GDBRemoteCapture.in --capture %t.repro -- %t.out | FileCheck %s --check-prefix CHECK --check-prefix CAPTURE
-# RUN: %lldb -x -b -s %S/Inputs/GDBRemoteReplay.in --replay %t.repro -- %t.out | FileCheck %s --check-prefix CHECK --check-prefix REPLAY
+# RUN: %lldb -x -b -s %S/Inputs/GDBRemoteCapture.in --capture %t.repro %t.out | FileCheck %s --check-prefix CHECK --check-prefix CAPTURE
+# RUN: %lldb --replay %t.repro | FileCheck %s --check-prefix CHECK --check-prefix REPLAY
# CHECK: Breakpoint 1
# CHECK: Process {{.*}} stopped
Index: lit/Reproducer/TestFileRepro.test
===================================================================
--- lit/Reproducer/TestFileRepro.test
+++ lit/Reproducer/TestFileRepro.test
@@ -7,9 +7,9 @@
# that the string "testing" is not printed.
# RUN: %clang %S/Inputs/simple.c -g -o %t.out
-# RUN: %lldb -x -b -s %S/Inputs/FileCapture.in --capture %t.repro -- %t.out | FileCheck %s --check-prefix CHECK --check-prefix CAPTURE
+# RUN: %lldb -x -b -s %S/Inputs/FileCapture.in --capture %t.repro %t.out | FileCheck %s --check-prefix CHECK --check-prefix CAPTURE
# RUN: rm %t.out
-# RUN: %lldb -x -b -s %S/Inputs/FileReplay.in --replay %t.repro -- %t.out | FileCheck %s --check-prefix CHECK --check-prefix REPLAY
+# RUN: %lldb --replay %t.repro | FileCheck %s --check-prefix CHECK --check-prefix REPLAY
# CAPTURE: testing
# REPLAY-NOT: testing
Index: lit/Reproducer/Inputs/FileReplay.in
===================================================================
--- lit/Reproducer/Inputs/FileReplay.in
+++ lit/Reproducer/Inputs/FileReplay.in
@@ -1,2 +0,0 @@
-reproducer status
-run
Index: lit/Reproducer/Inputs/GDBRemoteReplay.in
===================================================================
--- lit/Reproducer/Inputs/GDBRemoteReplay.in
+++ lit/Reproducer/Inputs/GDBRemoteReplay.in
@@ -1,5 +0,0 @@
-reproducer status
-breakpoint set -f simple.c -l 12
-run
-bt
-cont
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
