jingham added a comment.
Ah, I see what happened.
stop-hooks should always be run in asynchronous mode, it doesn't make sense to
have a stop hook persist over a continue. The intention is still to do that,
as indicated by the fact that we set StopOnContinue to true in the options we
pass to handle command when we run the stop hooks. These options were added in
a (nice mostly) refactor of HandleCommands. But StopOnContinue is incorrectly
handled. CommandInterpreter::HandleCommands just does:
if (!options.GetStopOnContinue()) {
m_debugger.SetAsyncExecution(false);
}
So if you pass stop on continue as true then we don't actually change the
sync/async mode of the debugger. So it it was synchronous going in, it's going
to stay that way. That's clearly incorrect.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58257/new/
https://reviews.llvm.org/D58257
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
