mgorny added a comment.

In D58230#1398020 <https://reviews.llvm.org/D58230#1398020>, @krytarowski wrote:

> For EINTR we shall use `llvm::sys::RetryAfterSignal`


`kevent()` man page indicates:

> All changes contained in the changelist are applied before any pending events 
> are read from the queue.

Also:

> [EINTR]            A signal was delivered before the timeout expired and 
> before any events were placed on the kqueue for return.

So while it's not stated explicitly, I think `in_events` is always consumed, 
even if EINTR is returned. In which case, `llvm::sys::RetryAfterSignal` would 
be wrong whenever `in_events` is not empty.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58230/new/

https://reviews.llvm.org/D58230



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to