mgorny created this revision. mgorny added reviewers: krytarowski, labath. mgorny added a project: LLDB. Herald added a subscriber: abidh.
Remove the redundant termination clause from within the loop. Since the check is done at the end of the loop, it's entirely redundant to the 'while' condition. If termination was requested, the latter will become false and the 'while' loop will terminate, resulting in the 'return' statement below the loop being executed (which is equivalent to the one used inside 'if'). Repository: rLLDB LLDB https://reviews.llvm.org/D58227 Files: lldb/source/Host/common/MainLoop.cpp Index: lldb/source/Host/common/MainLoop.cpp =================================================================== --- lldb/source/Host/common/MainLoop.cpp +++ lldb/source/Host/common/MainLoop.cpp @@ -380,9 +380,6 @@ return error; impl.ProcessEvents(); - - if (m_terminate_request) - return Status(); } return Status(); }
Index: lldb/source/Host/common/MainLoop.cpp =================================================================== --- lldb/source/Host/common/MainLoop.cpp +++ lldb/source/Host/common/MainLoop.cpp @@ -380,9 +380,6 @@ return error; impl.ProcessEvents(); - - if (m_terminate_request) - return Status(); } return Status(); }
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits