Hui added a comment. In D56237#1394320 <https://reviews.llvm.org/D56237#1394320>, @labath wrote:
> I like the direction this is going. I have one small comment about the code > organization inline, but the bigger question I have in mind is: After these > changes, is there any use for `Host::GetProcessBaseAddress` left? If so, what > is it? I'd like to understand it and remove it. From my understanding, lldb-server.exe is to debug a process instantiated by NativeProcessProtocol which might or might not relate to ProcessWindows plugin. To remove the host codes mentioned above, it requires the implementation of NativeProcessProtocol also notify the DYLD the load address of the main executable otherwise DYLD has to do the job with the OS help. For now I think just remove them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56237/new/ https://reviews.llvm.org/D56237 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
