JDevlieghere added a comment.
The change itself looks fine, just a few nits inline.
================
Comment at: include/lldb/Symbol/SourceModule.h:24
+
+};
+
----------------
Can you run clang-format on this? (It will add `// namespace lldb_private`
here.)
================
Comment at: source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:266
- for (size_t ci = 1; ci < path.size(); ++ci) {
- llvm::StringRef component = path[ci].GetStringRef();
+ for (size_t ci = 1; ci < module.path.size(); ++ci) {
+ llvm::StringRef component = module.path[ci].GetStringRef();
----------------
Can we make this `i`?
================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:941
+
+ if (const char *name =
+ module_die.GetAttributeValueAsString(DW_AT_name, nullptr)) {
----------------
Can we use a StringRef here?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58090/new/
https://reviews.llvm.org/D58090
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
