yurydelendik added a comment. In D57689#1384148 <https://reviews.llvm.org/D57689#1384148>, @jingham wrote:
> Could you add a test for this setting to the > ./functionalities/jitloader_gdb/TestJITLoaderGDB.py test? Added tests In D57689#1384894 <https://reviews.llvm.org/D57689#1384894>, @labath wrote: > Do we need both this and the `enable-jit-breakpoint` setting? My impression > was that the latter was meant to be used for disabling the gdb jit feature. > Is the gdb plugin useful for anything if it does not set the breakpoint (i.e. > enable = on, but enable-jit-bkpt = off). If it isn't, then could we just > remove the latter? Every time I tried to investigate that, I came to conclusion that it was just added as alternative for `enable`, but with intent to test plugin instantiation. Remoing in this patch. I can revert this change as needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57689/new/ https://reviews.llvm.org/D57689 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
