zturner marked an inline comment as done. zturner added inline comments.
================ Comment at: lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:318 + + TypeSystem *type_system = GetTypeSystemForLanguage(lldb::eLanguageTypeC_plus_plus); + if (!type_system) ---------------- amccarth wrote: > Is it appropriate to hard code that language type here? I realize we don't > have good PDB support of many other languages, but what about C? Or various > versions of C++? Well, the question is really whether any of those other languages would ever use a different type system. IMHO, the Language enumeration specifies too many unnecessary values (YAGNI), and it really should just be "some flavor of C" and "Swift", since no other type systems are even supported (and even Swift is downstream, so probably shouldn't even be in the upstream repo). The entire plugin (and indeed, pretty much all of LLDB) is already coupled very tightly with clang, and what flavor of C++ we're using won't matter for which TypeSystem we need (which is going to be `ClangASTContext` every single time, no exceptions). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56418/new/ https://reviews.llvm.org/D56418 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
