labath added a reviewer: stella.stamenova. labath added a comment. This looks fine to me. I recommend including Stella in changes relating to this, as I recall some subtleties here wrt. multi-config (e.g., MSVC) generators.
================ Comment at: CMakeLists.txt:43 if(LLDB_INCLUDE_TESTS) + # FIXME: LLDB_TEST_CXX_COMPILER is unused. + # FIXME: In standalone builds LLVM_BINARY_DIR points to LLDB's build directory and not to LLVM's! ---------------- JDevlieghere wrote: > Why is this unused? Are we only using `LLDB_TEST_C_COMPILER` and if so, why? I think that's because this only gets passed to dotest, that it has it's own logic for deducing the C++ compiler name. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56400/new/ https://reviews.llvm.org/D56400 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
