vsk added a comment. Looks like a nice/reasonable cleanup, thanks!
Based on the coverage report (https://teemperor.de/lldb-coverage/coverage/Users/vsk/src/llvm.org-lldbsan/llvm/tools/lldb/source/Breakpoint/BreakpointList.cpp.html#L217) and benchmarks (https://teemperor.de/lldb-bench/static.html) GetBreakpointAtIndex doesn't looks that hot, so I'm not sure it's worth changing / accidentally regressing. ================ Comment at: source/Breakpoint/BreakpointList.cpp:196 const BreakpointSP BreakpointList::GetBreakpointAtIndex(size_t i) const { std::lock_guard<std::recursive_mutex> guard(m_mutex); ---------------- Just call the non-const overload and const_cast? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56425/new/ https://reviews.llvm.org/D56425 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
