zturner added inline comments.
================ Comment at: source/Plugins/Platform/Windows/PlatformWindows.cpp:189-195 + else { + if (m_remote_platform_sp) + return m_remote_platform_sp->RunShellCommand( + command, working_dir, status_ptr, signo_ptr, command_output, timeout); + else + return Status("unable to run a remote command without a platform"); + } ---------------- Remove the `else` here since the if branch already has a return. ================ Comment at: source/Plugins/Platform/Windows/PlatformWindows.cpp:193-194 + command, working_dir, status_ptr, signo_ptr, command_output, timeout); + else + return Status("unable to run a remote command without a platform"); + } ---------------- And this else too. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56232/new/ https://reviews.llvm.org/D56232 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits