> > I guess I don't see why we need a temporary solution at all. If we can > have logic that can be rolled into the SymbolVendor when we get it, and > makes sense there, and is also simple, why not go with it? Failing that, > doesn't the `target symbols add` solution also work fine? >
I just checked again, and "target symbols add" depends on having a real SymbolVendor implementation. So unfortunately we still need a temporary solution. So far we're left with: 1) look in the current directory 2) look in the same directory as the .dmp file (we can't use the .exe/.dll locations since we don't have them in this case) I know we had a bit of back and forth about this. After revisiting the code (and for what is worth taking Visual Studio and windbg behavior in consideration), I still think that the current directory is the best choice. It's consistent with what LLDB already does for DWARF, so it's not adding another magic lookup. On Tue, Dec 11, 2018 at 3:41 PM Adrian McCarthy <amcca...@google.com> wrote: > > But here, we're talking about a situation where there is no EXE, only > a minidump. If there is a minidump and no EXE then neither WinDbg nor VS > will search the minidump folder for the PDB. > > For the record, the experiments do not bear this out. VS will indeed > search in the minidump folder for the PDB. Unfortunately, a lot of this > conversation was taken offline. > > On Tue, Dec 11, 2018 at 3:30 PM Zachary Turner via Phabricator < > revi...@reviews.llvm.org> wrote: > >> zturner added a comment. >> >> In D55142#1326247 <https://reviews.llvm.org/D55142#1326247>, @lemo wrote: >> >> > > How large is the PDB file here? >> > >> > ~100kb >> >> >> We have a couple of tests in LLVM where PDB files are checked in, but >> they are very few. We cannot explode the repo with large numbers of binary >> files. So this is probably fine, but if this becomes a pattern, we will >> need to come up with a different solution. >> >> >> CHANGES SINCE LAST ACTION >> https://reviews.llvm.org/D55142/new/ >> >> https://reviews.llvm.org/D55142 >> >> >> >>
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
