clayborg added a comment. In D55522#1326955 <https://reviews.llvm.org/D55522#1326955>, @labath wrote:
> It just occurred to me that we have another copy of /proc/<pid>/maps -> > MemoryRegionInfo conversion code. It lives in NativeProcessLinux.cpp > (ParseMemoryRegionInfoFromProcMapsLine). It would be nice to extract this > parser into a some place (`Plugins/Process/Utility` ?), where it can be > shared by the two process plugins. As a bonus, that should make it easy to > write unit tests for that function. Nice! I should have looked around. I will move it to Plugins/Process/Utility as suggested CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55522/new/ https://reviews.llvm.org/D55522 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
