labath marked 2 inline comments as done.
labath added inline comments.

================
Comment at: source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:1677
       // Check to see if the module was read from memory?
-      if (module_sp->GetObjectFile()->GetHeaderAddress().IsValid()) {
+      if (module_sp->GetObjectFile()->GetBaseAddress().IsValid()) {
         // We have a module that is in memory and needs to have its file
----------------
clayborg wrote:
> Switching to IsInMemory will work. This code probably predates the existence 
> of IsInMemory().
Ok, I'll check this in separately, as this is the only functional change in 
this commit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55422/new/

https://reviews.llvm.org/D55422



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to