labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
Looks good, modulo the filesystem copy comment. ================ Comment at: source/Commands/CommandCompletions.cpp:180 + FileSystem fs = FileSystem::Instance(); std::error_code EC; ---------------- This should surely be a reference, no? Making a copy of a filesystem sounds weird (and should probably be forbidden by deleting the copy constructor). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55240/new/ https://reviews.llvm.org/D55240 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
