echristo added a comment. In D54747#1312161 <https://reviews.llvm.org/D54747#1312161>, @ruiu wrote:
> Thank you for the patch. > > What you are doing in this patch is not too complicated and makes sense to > me. That said, if actual size saving is not significant as you said in > https://github.com/rust-lang/rust/issues/56068#issuecomment-440160568, it may > not be worth doing. It seems to me that if debug info is already 2.4GB, > shrinking it to 2GB doesn't make much difference. Do you have more convincing > examples? 400MB is 400MB... or, if you'd prefer 17% of overall size that was mentioned there. Additional testing might be nice in order to get a better idea of what we're looking at in practice (I guess a clang build would be another good choice), but the overall patch seems to be small and in a lot of ways simplifying for how we're linking. Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54747/new/ https://reviews.llvm.org/D54747 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
