lemo accepted this revision. lemo added inline comments. This revision is now accepted and ready to land.
================ Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:329 +std::pair<size_t, bool> GetIntegralTypeInfo(TypeIndex ti, TpiStream &tpi) { + if (ti.isSimple()) { ---------------- Just a suggestion: I'm not a big fan of returning std::pair<>. I'd use a simple struct instead. https://reviews.llvm.org/D54452 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits