jingham added a comment.

We do compose the decorators in a bunch of places (like Shafik's usage here).  
That will work more naturally if the categories that the decorators assert are 
as decoupled as possible.  So the statement about macos version should only 
skip the test if the os is macos, and make no comment about other os's.  That 
decouples the macos_version test from the oslist test, and allows something 
like the construct in the tests that Shafik wrote, which seems a pretty natural 
way to express "if on macOS, it has to be version > x, otherwise it has to be 
clang > y".


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53208



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to