grimar added inline comments.
================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp:442
+ ReadDescriptors(debug_line_data, offset_ptr);
+ uint8_t dirCount = debug_line_data.GetU8(offset_ptr);
+ for (int i = 0; i < dirCount; ++i) {
----------------
probinson wrote:
> clayborg wrote:
> > We might verify that this is indeed correct by looking at compiler sources.
> > Seems weird to limit dirs to 255
> The directory count is a ULEB not a ubyte.
Oops. My mistake here, my initial version which used uleb128 was correct, but I
looked at the wrong place too in the dwarf5 spec after that.
https://reviews.llvm.org/D51935
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
