xiaobai created this revision.
xiaobai added reviewers: clayborg, labath.
Herald added a subscriber: mgorny.

Building LLDB with xcodebuild sets the compatability version of liblldb
in LLDB.framework. Building the framework with cmake does not set the
compatability version, and so it defaults to 0.0.0. This is a discrepency in the
difference between the xcode build and the cmake build.

I tested this change by building without this patch. From the build tree I ran
`otool -L Library/Frameworks/LLDB.framework/Versions/A/LLDB` and got this:

  @rpath/LLDB.framework/Versions/A/LLDB (compatibility version 0.0.0, current 
version 8.0.0)

Did the same with this patch and the output contained this:

  @rpath/LLDB.framework/Versions/A/LLDB (compatibility version 1.0.0, current 
version 8.0.0)


https://reviews.llvm.org/D51959

Files:
  source/API/CMakeLists.txt


Index: source/API/CMakeLists.txt
===================================================================
--- source/API/CMakeLists.txt
+++ source/API/CMakeLists.txt
@@ -146,6 +146,7 @@
 if (LLDB_BUILD_FRAMEWORK)
   set_target_properties(liblldb
     PROPERTIES
+    SOVERSION "1.0.0"
     OUTPUT_NAME LLDB
     FRAMEWORK On
     FRAMEWORK_VERSION ${LLDB_FRAMEWORK_VERSION}


Index: source/API/CMakeLists.txt
===================================================================
--- source/API/CMakeLists.txt
+++ source/API/CMakeLists.txt
@@ -146,6 +146,7 @@
 if (LLDB_BUILD_FRAMEWORK)
   set_target_properties(liblldb
     PROPERTIES
+    SOVERSION "1.0.0"
     OUTPUT_NAME LLDB
     FRAMEWORK On
     FRAMEWORK_VERSION ${LLDB_FRAMEWORK_VERSION}
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to