aleksandr.urakov added inline comments.

================
Comment at: lldb/trunk/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:268-269
+
+std::unique_ptr<llvm::pdb::PDBSymbol>
+GetClassOrFunctionParent(const llvm::pdb::PDBSymbol &symbol) {
+  const IPDBSession &session = symbol.getSession();
----------------
zturner wrote:
> All file local functions should be marked `static`.
But this function is already belonging to `anonymous namespace`, what `static` 
actually means in C++. Do you think that it's still necessary?


Repository:
  rL LLVM

https://reviews.llvm.org/D51162



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
    • ... Zachary Turner via lldb-commits
      • ... Zachary Turner via Phabricator via lldb-commits
  • [Ll... Aaron Smith via Phabricator via lldb-commits
  • [Ll... Aleksandr Urakov via Phabricator via lldb-commits
  • [Ll... Aleksandr Urakov via Phabricator via lldb-commits
  • [Ll... Stella Stamenova via Phabricator via lldb-commits
  • [Ll... Aleksandr Urakov via Phabricator via lldb-commits
  • [Ll... Ted Woodward via Phabricator via lldb-commits
  • [Ll... Zachary Turner via Phabricator via lldb-commits
  • [Ll... Aleksandr Urakov via Phabricator via lldb-commits
  • [Ll... Aleksandr Urakov via Phabricator via lldb-commits
  • [Ll... Aleksandr Urakov via Phabricator via lldb-commits
    • ... Zachary Turner via lldb-commits
      • ... Aleksandr Urakov via lldb-commits
        • ... Zachary Turner via lldb-commits
          • ... Aleksandr Urakov via lldb-commits
  • [Ll... Aleksandr Urakov via Phabricator via lldb-commits
  • [Ll... Aleksandr Urakov via Phabricator via lldb-commits
    • ... Zachary Turner via lldb-commits
      • ... Mailing List "llvm-commits" via Phabricator via lldb-commits

Reply via email to