erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land.
LGTM, thanks for doing this! ================ Comment at: unittests/Demangle/PartialDemangleTest.cpp:188 + size_t N = OriginalSize; + char *Res = D.getFunctionName(Buf, &N); + EXPECT_EQ(nullptr, Res); ---------------- Does LLDB actually pass in a N that is less than the length of Buf? Its not wrong to do that per se, realloc will sort it out, but it seems kinda strange. Repository: rL LLVM https://reviews.llvm.org/D50473 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
