sgraenitz marked an inline comment as done. sgraenitz added inline comments.
================ Comment at: source/Core/Mangled.cpp:239-240 +//---------------------------------------------------------------------- +namespace { + +char *GetMSVCDemangledStr(const char *M) { ---------------- jingham wrote: > The LLVM conventions suggest only putting declarations in the anon namespace, > and then having the definitions out of line: > > http://www.llvm.org/docs/CodingStandards.html#anonymous-namespaces Right. Well that's a C function, so removed anon namespace and declared static. https://reviews.llvm.org/D50071 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits