The new test cases did catch a real bug:
[ RUN ] VMRange.CollectionContains
llvm/src/tools/lldb/unittests/Utility/VMRangeTest.cpp:146: Failure
Value of: VMRange::ContainsRange(collection, VMRange(0x100, 0x104))
Actual: false
Expected: true
class RangeInRangeUnaryPredicate {
public:
RangeInRangeUnaryPredicate(VMRange range) : _range(range) {} // note that
_range binds to a temporary!
bool operator()(const VMRange &range) const {
return range.Contains(_range);
}
const VMRange &_range;
};
I just sent out a review for the fix (https://reviews.llvm.org/D50290)
On Tue, Jul 24, 2018 at 4:53 PM, Raphael Isemann via Phabricator via
lldb-commits <lldb-commits@lists.llvm.org> wrote:
> This revision was not accepted when it landed; it landed in state "Needs
> Review".
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL337873: Add unit tests for VMRange (authored by
> teemperor, committed by ).
> Herald added a subscriber: llvm-commits.
>
> Changed prior to commit:
> https://reviews.llvm.org/D49415?vs=157172&id=157173#toc
>
> Repository:
> rL LLVM
>
> https://reviews.llvm.org/D49415
>
> Files:
> lldb/trunk/unittests/Utility/CMakeLists.txt
> lldb/trunk/unittests/Utility/VMRangeTest.cpp
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
>
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
