>
> I'm not sure if there is a suitable place for that function. This is
> needed in "ObjectFileMachO" and two dynamic loader plugins.
Then your factory idea may be the next best thing. While we're at it, maybe
we can remove the UUID::SetBytes() from the public interface, and make the
UUID an immutable value type:
Ex. instead of:
UUID uuid;
...
uuid.SetBytes(...)
We'd have:
UUID uuid;
uuid = UUID(...);
// or
uuid = { ... };
// or
uuid = UUID::factory(...);
What do you think?
On Fri, Jun 22, 2018 at 12:29 PM, Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath added a comment.
>
> In https://reviews.llvm.org/D48479#1141067, @lemo wrote:
>
> > One solution might be to encapsulate the MachO convention in the MachO
> >
> > code: check in there (maybe through a helper function) if the UUID is
> > "000...0" and map it to the empty UUID in that case. The UUID interface
> > would not have to know/care about this convention. Would this work?
>
>
> I'm not sure if there is a suitable place for that function. This is
> needed in "ObjectFileMachO" and two dynamic loader plugins.
>
>
> https://reviews.llvm.org/D48479
>
>
>
>
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
