labath added a comment. In https://reviews.llvm.org/D48272#1135373, @clayborg wrote:
> Looks good. My only question is do we not require people to only fill in the > directory portion of the FileSpec anymore for these functions? I am fine with > way since hopefully FileSpec::AppendPathComponent handles things correctly. I'm not sure if anyone actually depends on this behavior, but there is a test which actually requires this (TestPaths.py). I did consider dropping this promise for the internal API and doing the fixup in the SB layer, but I chose not to go along with that for now. I believe AppendPathComponent et al. will mostly work for these kinds of FileSpecs, but they are definitely a less well tested path. https://reviews.llvm.org/D48272 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
