JDevlieghere added a comment.

In https://reviews.llvm.org/D47535#1116364, @labath wrote:

> Actually, I wonder if we shouldn't just deprecate this function altogether. 
> What was your motivation for this patch? It seems we already have 
> `llvm::fs::(recursive_)directory_iterator` for this purpose. It would be 
> great if we could use that for all new code. Have you looked at that?


My motivation is https://reviews.llvm.org/D47539. I could use the iterators 
directly but since the FileSpec one is based on them anyway (and adds some 
functionality that is actually useful) I figured I might as well use them for 
consistency. I'm not opposed to using the iterators directly, but won't that'll 
result in more code?


Repository:
  rL LLVM

https://reviews.llvm.org/D47535



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to