clayborg added inline comments.
================ Comment at: source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:153 + return true; + bool looking_for_methods = name_type_mask & eFunctionNameTypeMethod; + return looking_for_methods == die.IsMethod(); ---------------- move up to line 150 and use this variable in the if statement instead of repeating "name_type_mask & eFunctionNameTypeMethod" twice? ================ Comment at: source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp:222 + return true; + return GetReferencedDIE(DW_AT_specification) + .GetParent() ---------------- I can never remember when a DW_AT_abstract_origin might be used. Might be nice to have a DWARFDIE method: ``` DWARFDIE DWARFDIE::GetAbstractOriginOrSpecification(); ``` this would return either the the DW_AT_specification or the DW_AT_abstract_origin. If we go that route the this coce would become: ``` GetAbstractOriginOrSpecification().GetParent().IsStructUnionOrClass(); ``` https://reviews.llvm.org/D47470 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
