Author: jankratochvil Date: Fri May 25 09:11:45 2018 New Revision: 333287 URL: http://llvm.org/viewvc/llvm-project?rev=333287&view=rev Log: Remove DWARFUnit::ClearDIEs parameter keep_compile_unit_die
It has been now always passed as true and during planned D46810 it would no longer make sense. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.h lldb/trunk/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp?rev=333287&r1=333286&r2=333287&view=diff ============================================================================== --- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp (original) +++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp Fri May 25 09:11:45 2018 @@ -288,7 +288,7 @@ void DWARFUnit::SetAddrBase(dw_addr_t ad m_base_obj_offset = base_obj_offset; } -void DWARFUnit::ClearDIEs(bool keep_compile_unit_die) { +void DWARFUnit::ClearDIEs() { if (m_die_array.size() > 1) { // std::vectors never get any smaller when resized to a smaller size, or // when clear() or erase() are called, the size will report that it is @@ -300,12 +300,11 @@ void DWARFUnit::ClearDIEs(bool keep_comp // Save at least the compile unit DIE DWARFDebugInfoEntry::collection tmp_array; m_die_array.swap(tmp_array); - if (keep_compile_unit_die) - m_die_array.push_back(tmp_array.front()); + m_die_array.push_back(tmp_array.front()); } if (m_dwo_symbol_file) - m_dwo_symbol_file->GetCompileUnit()->ClearDIEs(keep_compile_unit_die); + m_dwo_symbol_file->GetCompileUnit()->ClearDIEs(); } void DWARFUnit::BuildAddressRangeTable(SymbolFileDWARF *dwarf, @@ -403,7 +402,7 @@ void DWARFUnit::BuildAddressRangeTable(S // Keep memory down by clearing DIEs if this generate function caused them to // be parsed if (clear_dies) - ClearDIEs(true); + ClearDIEs(); } lldb::ByteOrder DWARFUnit::GetByteOrder() const { Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.h?rev=333287&r1=333286&r2=333287&view=diff ============================================================================== --- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.h (original) +++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.h Fri May 25 09:11:45 2018 @@ -99,7 +99,7 @@ public: dw_addr_t GetRangesBase() const { return m_ranges_base; } void SetAddrBase(dw_addr_t addr_base, dw_addr_t ranges_base, dw_offset_t base_obj_offset); - void ClearDIEs(bool keep_compile_unit_die); + void ClearDIEs(); void BuildAddressRangeTable(SymbolFileDWARF *dwarf, DWARFDebugAranges *debug_aranges); Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp?rev=333287&r1=333286&r2=333287&view=diff ============================================================================== --- lldb/trunk/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp (original) +++ lldb/trunk/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp Fri May 25 09:11:45 2018 @@ -96,7 +96,7 @@ void ManualDWARFIndex::Index() { //---------------------------------------------------------------------- for (uint32_t cu_idx = 0; cu_idx < num_compile_units; ++cu_idx) { if (clear_cu_dies[cu_idx]) - debug_info.GetCompileUnitAtIndex(cu_idx)->ClearDIEs(true); + debug_info.GetCompileUnitAtIndex(cu_idx)->ClearDIEs(); } } _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits