polyakov.alex added a comment.

In https://reviews.llvm.org/D47302#1110441, @aprantl wrote:

> The missing context here is that the lldb-mi -target-select command currently 
> calls `HandleCommand("target modules search-paths add", ...)`.
>  Is adding a new SBAPI the right approach to implementing this functionality 
> without going through HandleCommand? Or is HandleCommand appropriate in this 
> case?


This approach is not mandatory, we could do almost the same(except errors 
processing) right in TargetSelect::Execute method. As you can see, the main 
thing here is:

  target_sp->GetImageSearchPathList().Append(
            ConstString(from), ConstString(to), true);


Repository:
  rL LLVM

https://reviews.llvm.org/D47302



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to