clayborg added a comment. In https://reviews.llvm.org/D47278#1110164, @xiaobai wrote:
> In https://reviews.llvm.org/D47278#1110155, @clayborg wrote: > > > sorry, not as a test, but just as a way to figure out if we are getting all > > the needed header files when we modify this framework header file copying > > code. > > > Ah, yeah. I'm in the process of trying to build LLDB.framework with > cmake+ninja and get the same thing as when you build with xcodebuild. > As far as headers go, we roughly have parity after this change. CMake copies > SystemInitializerFull.h into LLDB.Framework/Headers while Xcode doesn't, but > I'm not sure that actually matters that much. It does as we can't expose any lldb_private functions and this exposes lldb_private::SystemInitializerFull which requires lldb_private::SystemInitializerCommon. The only references to stuff inside lldb_private in headers that make it into the LLDB.framework can be forward references like: namespace lldb_private { class Foo; } https://reviews.llvm.org/D47278 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
