[Lldb-commits] [PATCH] D46783: FileSpec objects that resolve to "." should have "." in m_filename and m_directory empty.

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

So I made a fix to LLVM and there are tests that are testing for the empty 
string:

[ RUN      ] Support.RemoveDots
/Users/gclayton/Documents/src/llvm/clean/llvm/unittests/Support/Path.cpp:1149: 
Failure

  Expected: ""

To be equal to: remove_dots(".\\\\\\\\\\", false, path::Style::windows)

  Which is: "."

/Users/gclayton/Documents/src/llvm/clean/llvm/unittests/Support/Path.cpp:1166: 
Failure

  Expected: ""

To be equal to: remove_dots("./////", false, path::Style::posix)

  Which is: "."

Are we not concerned with this?


https://reviews.llvm.org/D46783



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits