labath added inline comments.

================
Comment at: source/Utility/FileSpec.cpp:277-281
+  auto style = LLVMPathSyntax(syntax);
+  m_filename.SetString(llvm::sys::path::filename(resolved, style));
+  llvm::StringRef dir = llvm::sys::path::parent_path(resolved, style);
+  if (!dir.empty())
+    m_directory.SetString(dir);
----------------
clayborg wrote:
> Does this work ok in LLVM if the slashes have already been switched on line 
> 275? We would specify a syntax of windows, but the slashes would be wrong?
That's not a problem. in the windows path style, the llvm functions treat both 
kinds of slashes as directory separators.


https://reviews.llvm.org/D46687



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to