clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land.
main problem with this approach is if the client tries to lookup "reference_type" as an example... It will end up pulling in and completing every STL type and returning the typedef only for us to weed this out. Nothing we can do about this at the moment unless we make our SymbolFile::FindType() take some extra parameters where we can specify a decl content in an abstract way (like "at the tranlsation unit level, find me 'reference_unit', or "in class A and in class B find 'reference_type'". For now we could try to specify a parent_decl_context that is the translation unit, but we would need to fix the lookup code to fill in the correct translation unit for each module. So for now, this works and is our best solution, but there are many problems with out type lookup that do need to be fixed, but those will need to happen later. https://reviews.llvm.org/D46548 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
