stella.stamenova added inline comments.

================
Comment at: test/CMakeLists.txt:138
 if(CMAKE_HOST_APPLE)
-  list(APPEND LLDB_TEST_COMMON_ARGS --server ${DEBUGSERVER_PATH})
+  if (DEBUGSERVER_PATH STREQUAL "$<TARGET_FILE:debugserver>")
+    list(APPEND LLDB_EXECUTABLE_PATH_ARGS --server ${DEBUGSERVER_PATH})
----------------
I am wondering if it's possible to make the logic here simpler. Since we need 
to handle each of the properties that can contain TARGET_FILE, it is starting 
to get rather complicated

I think you can actually use LLDB_DOTEST_ARGS_STR for the check-lldb-single 
target (since it creates a project that should be correctly substituted), so 
the only other place that could create issues is the lldb-dotest script. Since 
the tests are run as part of lit now, do we still need the lldb-dotest script?



Repository:
  rL LLVM

https://reviews.llvm.org/D46334



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to