alexandreyy added a comment. In https://reviews.llvm.org/D44472#1038656, @labath wrote:
> I wonder if we shouldn't just fix the TestDisassembleBreakpoint to not > require adding every single architecture. That test was added because > lldb-server was not removing the traps from the memory read packets. This is > something that is completely independent of us later trying to disassemble > the memory we got back. To test that, it should be sufficient to compare the > memory contents before and after setting a breakpoint. > > Guessing what instructions will the compiler emit for a particular piece of C > will just make the test fragile... I executed the tests again and we don't really need both powerpc64le and ppc64le. Some tests required "ppc64le" to be built. But they are working now without it. I modified the disassemble test as you suggested. https://reviews.llvm.org/D44472 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
