labath added a comment.

Pretty close, just a couple of style issues.



================
Comment at: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp:62
   if (!valobj_backend_sp)
-    return false;
+    return NULL;
 
----------------
nullptr.


================
Comment at: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp:78
+    return obj_subchild_sp;
+  } else {
+    return obj_child_sp;
----------------
no else after return


https://reviews.llvm.org/D44015



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
  • [Lldb-commits] ... Alexandre Yukio Yamashita via Phabricator via lldb-commits
    • [Lldb-comm... Pavel Labath via Phabricator via lldb-commits
    • [Lldb-comm... Alexandre Yukio Yamashita via Phabricator via lldb-commits
    • [Lldb-comm... Pavel Labath via Phabricator via lldb-commits
    • [Lldb-comm... Alexandre Yukio Yamashita via Phabricator via lldb-commits
    • [Lldb-comm... Alexandre Yukio Yamashita via Phabricator via lldb-commits
    • [Lldb-comm... Pavel Labath via Phabricator via lldb-commits

Reply via email to